Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSR Token instead of OIDC #943

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Use JSR Token instead of OIDC #943

merged 1 commit into from
Dec 21, 2024

Conversation

taras
Copy link
Member

@taras taras commented Dec 21, 2024

Motivation

OIDC is the recommended way of authenticating from GitHub Actions to JSR, but it requires that the person who triggered the workflow (i.e., the person who merged the code that triggered the workflow) be a member of the package scope in JSR. We want FrontsideJack to be the only one with scope membership, so we can't use OIDC.

Approach

Created a token for FrontsideJack in JSR that's scoped to only publish to effection package, added the token as a secret to the effection repository and passing the token via jsr publish --token.

@taras taras requested a review from cowboyd December 21, 2024 00:19
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add, that it is a feature that the maintainers list of the affection repository does not need to be perfectly in sync with the org admin of JSR for the release process to work.

As it stands if we we have a maintainer of the GitHub repository who is not also an admin on the JSR.io our release process won't work guaranteed.

@taras taras merged commit 6c46597 into v3 Dec 21, 2024
5 checks passed
@taras taras deleted the tm/switch-to-using-jsr-token branch December 21, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants