Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v4 to JSR #947

Merged
merged 7 commits into from
Dec 22, 2024
Merged

Publish v4 to JSR #947

merged 7 commits into from
Dec 22, 2024

Conversation

taras
Copy link
Member

@taras taras commented Dec 21, 2024

Motivation

I'm going to start migrating dependent projects to [email protected], so I'd like to have v4 available on JSr.

Approach

Cherry-picked commits from v3

* Generating jsr.json and publishing from GA

* Appending to deno.json instead

* Don't need jsr.json anymore

* Added missing explicit types and replaced jsr dependencies

* Upgraded deno/dnt

* Fix fomatting
@taras taras requested a review from cowboyd December 21, 2024 21:14
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I do wonder why isn't that our linting rules can't catch all of the extra constraints required by JSR. Is there a setting we can apply?

@taras
Copy link
Member Author

taras commented Dec 22, 2024

These are JSR-specific rules mostly to avoid slow types.

@taras taras merged commit 60b27e0 into v4 Dec 22, 2024
3 checks passed
@taras taras deleted the tm/publish-jsr branch December 22, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants