Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deno config for capat with 1.36.x (and earlier?) #65

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Sep 12, 2023

Motivation

The existing deno config was out of date with the current version of deno (1.36.4 at time of writing). Updating it.

@jbolda jbolda requested a review from cowboyd September 12, 2023 21:29
@jbolda
Copy link
Contributor Author

jbolda commented Sep 12, 2023

@cowboyd I was trying to bump the deno things so it runs with the latest. I am stuck on this error though. It runs fine locally, but the hash on the lockfile has a mismatch?

@jbolda
Copy link
Contributor Author

jbolda commented Sep 12, 2023

Ah, the https://esm.sh/#faq deps don't have stable hashes unless you also pin on the build version.

Why I get The source code is invalid... error in Deno?

Since Deno 1.18+ will generate the deno.lock file for the dependencies, but esm.sh builds code with different version of esbuild when you imports modules from different build version. To fix this issue, please try to pin the build version like https://esm.sh/react?pin=v132. Or use the CLI Script to manage the dependencies that will fix the build version automatically.

@jbolda jbolda merged commit 5a84250 into v1 Sep 14, 2023
1 check passed
@jbolda jbolda deleted the deno-config-updates-1.36.x branch September 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants