-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimenting with testing incremental ingestion #97
base: main
Are you sure you want to change the base?
Conversation
|
return this.pages | ||
} | ||
|
||
setData(data: Page[]) { this.pages = data } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of setData
, let's create a test client that we can control. The test client can be very simple but it'll be responsible for returning data or throwing errors to induce a specific state. This test client will be setup in around
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't call around
directly to setup client there and are able to control it. So either we create client outside and we just pass client to burst
in around
or we setup client in around
but we can't get a reference to it
📣 NOTIFICATION Generated by @thefrontside/actions |
Motivation
Approach
Alternate Designs
Possible Drawbacks or Risks
TODOs and Open Questions
Learning
Screenshots