Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimenting with testing incremental ingestion #97

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

taras
Copy link
Member

@taras taras commented Sep 16, 2022

Motivation

Approach

Alternate Designs

Possible Drawbacks or Risks

TODOs and Open Questions

Learning

Screenshots

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

⚠️ No Changeset found

Latest commit: d0f081d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

return this.pages
}

setData(data: Page[]) { this.pages = data }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setData, let's create a test client that we can control. The test client can be very simple but it'll be responsible for returning data or throwing errors to induce a specific state. This test client will be setup in around.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't call around directly to setup client there and are able to control it. So either we create client outside and we just pass client to burst in around or we setup client in around but we can't get a reference to it

@frontsidejack
Copy link
Member

frontsidejack commented Sep 20, 2022

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

@taras taras changed the title WIP Experimenting with testing incremental ingestion Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants