Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recommended labels #281

Merged
merged 1 commit into from
Sep 1, 2023
Merged

add recommended labels #281

merged 1 commit into from
Sep 1, 2023

Conversation

ghkadim
Copy link
Collaborator

@ghkadim ghkadim commented Aug 30, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

@ghkadim ghkadim force-pushed the k8s-recommended-labels branch 3 times, most recently from 8bcdf26 to bffbb06 Compare August 30, 2023 14:49
@ghkadim ghkadim merged commit 651b99e into main Sep 1, 2023
1 check passed
@ghkadim ghkadim deleted the k8s-recommended-labels branch September 1, 2023 09:46
fnovikov added a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants