Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the order of the links before and after the article at the bot… #1257

Closed
wants to merge 1 commit into from
Closed

Conversation

Perry961002
Copy link

@Perry961002 Perry961002 commented Nov 4, 2019

…tom of the page

PR Checklist

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

  • I found that there is a problem with the order of the links before and after the page. The link to the previous article should be displayed on the left under normal circumstances and now on the right.

What is the new behavior?

  • I modified the post.swig file under "layout/_macro/". The specific modification is the code snippet under "{% if not is_index and (post.prev or post.next) %}"
  • Screenshots with this changes:
  • Link to demo site with this changes: https://perry96.com/archives/531cca2c.html

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Nov 4, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2019

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Nov 4, 2019

I found that there is a problem with the order of the links before and after the page. The link to the previous article should be displayed on the left under normal circumstances and now on the right.

I don't quite understand. The link to the previous article should be displayed on the left, and yes, it is on the left.

https://theme-next.org/next-7-5-0-released/

Do you mean on the right? #983

NexT
⭐ Features Extract some features to plugins (#1232) Migrate to Nunjucks (#1215, #1218, #1220, #1226) Delete query strings (#963) 🛠 Improvements Replace lodash with native API (#1230) Refactor sub-me

@Perry961002
Copy link
Author

Perry961002 commented Nov 4, 2019

I found that there is a problem with the order of the links before and after the page. The link to the previous article should be displayed on the left under normal circumstances and now on the right.

I don't quite understand. The link to the previous article should be displayed on the left, and yes, it is on the left.

https://theme-next.org/next-7-5-0-released/

Do you mean on the right? #983

NexT**NexT 7.5.0 Released**⭐ Features Extract some features to plugins (#1232) Migrate to Nunjucks (#1215, #1218, #1220, #1226) Delete query strings (#963) 🛠 Improvements Replace lodash with native API (#1230) Refactor sub-me

yes

NexT
⭐ Features Extract some features to plugins (#1232) Migrate to Nunjucks (#1215, #1218, #1220, #1226) Delete query strings (#963) 🛠 Improvements Replace lodash with native API (#1230) Refactor sub-me

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Nov 4, 2019

Thanks for your contributing.

So, what you mean is

The link to the previous article should be displayed on the right under normal circumstances

Can you provide more evidence to prove it? The behavior of NexT is currently consistent with the wordpress convention.

@Perry961002
Copy link
Author

Thanks for your contributing.

So, what you mean is

The link to the previous article should be displayed on the right under normal circumstances

Can you provide more evidence to prove it? The behavior of NexT is currently consistent with the wordpress convention.

Sorry, I am saying that the current version shows the link to the old article on the left. Normally, the link to the new article should be placed on the left.

@stevenjoezhang
Copy link
Contributor

I think I have understood your thoughts.

displayed on the right under normal circumstances
Normally, the link to the new article should be placed on the left.

However, I can hardly agree that this is something normal. As I have said, can you provide any evidence to prove it? Thanks.

@Perry961002
Copy link
Author

I think I have understood your thoughts.

displayed on the right under normal circumstances
Normally, the link to the new article should be placed on the left.

However, I can hardly agree that this is something normal. As I have said, can you provide any evidence to prove it? Thanks.

  • I think this can be considered. Suppose there is a top-down timeline. We can look at it from the left side of it, so the new article should appear on the left side of the old article.

@jiangtj
Copy link
Member

jiangtj commented Nov 5, 2019

I think this part is ambiguous, so make it configurable, maybe better.

@stevenjoezhang
Copy link
Contributor

It is configurable. The order of each post is generated by Hexo, and controlled by index_generator.order_by option in Hexo _config.yml. It has nothing to do with theme NexT.

@stevenjoezhang
Copy link
Contributor

Superseded by 1417248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants