forked from airbnb/javascript
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint updates #6
Open
banderso-n
wants to merge
19
commits into
thenerdery:develop
Choose a base branch
from
banderso-n:feature/eslint-updates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a new eslint file reflecting the standards shortly.
# Conflicts: # linters/.eslintrc # linters/README.md
Adds tslint config
FYI there are some commits on master that are not on develop so I'd recommend merging master into develop. It should be done anyway, but it'll also make this PR easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates skeleton package for new eslint file with rules based on recent airbnb eslint audit https://docs.google.com/spreadsheets/d/1IFX1-EwKxGmF7VZCcEsVp2nu56WkJUhWKBbHLkECagc
STEPS TO TEST
Our eslint config will basically just override airbnb's for the few places where we disagree with them. So to test this config, setup airbnb's config (or base config if you're not using react) as you normally would, then add a line to the
extends
array in your eslint config to pull in these rules.1. Pull in the new eslint file (e.g. add this to your package.json)
2. Reference the eslint file in your config's "extends" array
3. Get testin'