Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspace & add nx directly instead of nrwl #23

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Clemsazert
Copy link

@Clemsazert Clemsazert commented Jan 24, 2024

This PR tries to fix all the issues I encountered during while trying to setup the keïko.

  • It seems pnpm 8 now requires a non empty array value for packages field in pnpm-workspace.yaml. Added the value "packages/*"
  • Failed to run any scripts using nxwith error nx: command not found, although it should be provided by @nrwl/cli package. Removed @nrwl/cli and @nrwl/tao and installed nx directly instead
  • For nx >= 17, workspace.json should be replaced by project.json fiels inside each package. As a fix I ran the command nx g @nx/workspace:fix-configuration as provided in nx migration documentation.
  • For nx >= 17, the syntax for declaring targetDependencies is different. It relies on targetDefaults => migrated to new declaration spec. Removed the nrwl runner as it was not available anymore.
  • Add a remove target in root package.json to make easier cleaning resources after the keïko
  • It seems there is a bug with caching in nx 17 (After upgrading to nx 17 cache directory setting seems ignored and produces a .nx directory at project root nrwl/nx#21120). Removed custom cache directory (.nx/cache by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant