This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
forked from navitronic/psymf
-
-
Notifications
You must be signed in to change notification settings - Fork 29
Experimental support for use of expressions in custom variables #78
Open
wayne530
wants to merge
1
commit into
theofidry:master
Choose a base branch
from
wayne530:ywh/poc-expression-variables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ | |
use Symfony\Component\HttpKernel\DependencyInjection\Extension; | ||
use function array_merge; | ||
use function is_string; | ||
use function preg_replace; | ||
use function sprintf; | ||
use function strpos; | ||
use function substr; | ||
|
@@ -50,16 +51,21 @@ public function load(array $configs, ContainerBuilder $container): void | |
|
||
$config = $this->processConfiguration(new Configuration(), $configs); | ||
|
||
$containerId = 'test.service_container'; | ||
|
||
foreach ($config['variables'] as $name => $value) { | ||
if (is_string($value) && strpos($value, '@') === 0) { | ||
$value = new Reference(substr($value, 1)); | ||
if (is_string($value)) { | ||
if (strpos($value, '@') === 0) { | ||
$value = new Reference(substr($value, 1)); | ||
} else if (strpos($value, '{') === 0) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned above I think if we are to introduce support for expressions we should we the "standard" expression? Or maybe I'm confusing with something else... Maybe OverblogGraphQLBundle YAML config |
||
$expression = preg_replace('/%containerId\b/', $containerId, substr($value, 1, -1)); | ||
$value = new Expression($expression); | ||
} | ||
} | ||
|
||
$config['variables'][$name] = $value; | ||
} | ||
|
||
$containerId = 'test.service_container'; | ||
|
||
$container | ||
->findDefinition('psysh.shell') | ||
->addMethodCall( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't
@=service('%containerId').get('doctrine')
be enough here?