add openx and criteo adapters to prebid #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craiget
commented
Apr 4, 2018
craiget
commented
- updates to Prebid v1.6.0
- adds Criteo adapter
- adds OpenX adapter
- updates build instructions in README.md
spra85
reviewed
Apr 5, 2018
| @@ -67,13 +67,15 @@ Download the latest version of PrebidJS | |||
| ``` | |||
| $ git clone https://github.com/prebid/Prebid.js.git | |||
| $ cd Prebid.js | |||
| $ git checkout 1.6.0 # optional | |||
There was a problem hiding this comment.
Should this be flagged as optional?
There was a problem hiding this comment.
Hm, up to you guys I think. Seems preferable to build a specific version rather than the bleeding edge, but either should work
spra85
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.