Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipArchiveAdapter changes for dealing with root dir ('') #1548

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Sep 7, 2022

This PR proposes the following changes for ZipArchiveAdapter:

  • When checking existence of root dir, check if file exists
  • When deleting root dir, delete file

- When checking existence of root dir, check if file exists
- When deleting root dir, delete file
@SamMousa
Copy link

This is a BC break for any code that externally access the zip file which may now no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants