-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix psr/simple-cache version constraint. Fixes #320 #321
base: 5.x
Are you sure you want to change the base?
Conversation
Widen psr/simple-cache version constraint to support 1.0|2.0|3.0. Fixes thephpleague#320
Sorry for the delay on this, will be merging and tagging early next week. |
This actually causes an issue on PHP 8 as there is a method signature change |
Hmm.. im using this in my composer.json {
"require": {
"psr/simple-cache": "3.0 as 1.0",
}
} and not getting any errors from router or anything and i have error_reporting set to E_ALL and running PHP 8.1 |
What was the error? The logs for the tests have been removed already :\ |
locking dependency on 1.0 causes conflicts as a lot of packages have moved on to 3.0 |
So what's the plan for this @philipobenito, can't these other dependencies be updated/upgraded as well? |
@philipobenito, sorry to push for this again, but can you elaborate, so we can move away from the 7-year old dependency? |
@philipobenito I investigated it myself, and understand the issue now. To be able to fix this, support for PHP7 needs to be dropped, which is what #327 is about. |
No takers? |
Dealing with health issues, will get to it as soon as I can
Sent from Proton Mail for iOS
…On Thu, Jan 26, 2023 at 07:42, Bart Vanderstukken ***@***.***> wrote:
No takers?
—
Reply to this email directly, [view it on GitHub](#321 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAP3E2KLPAENBIT46XPPXMLWUITHPANCNFSM5KW43WJA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Oh sorry to hear that, take care! |
@philipobenito did you have a change to look at this? |
any updates to this? |
Handled this locally for 6.x release, I know it's been promised before, but coming early next week |
Widen psr/simple-cache version constraint to support 1.0|2.0|3.0.
Fixes #320