Update screens for deposit and withdrawal flows #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
force-pushed
the
awaiting-modals
branch
from
eec8832
to
3952c51
Compare
The status will tell us when the wallet window opens and when the transaction is completed.
The "Skeleton" loading screen from both Deposit and Withdraw flows is no longer needed. The new flow adds two steps: - "Opening your wallet for signature" Screen - "Awaiting Transaction" Screen
kkosiorowska
force-pushed
the
awaiting-modals
branch
from
d7b5be7
to
9e6fbe6
Compare
We want to know when the transaction data are built. We add callback that is triggered after building data.
kkosiorowska
force-pushed
the
awaiting-modals
branch
from
730ce12
to
51a3965
Compare
| @@ -24,6 +25,7 @@ export function useDepositBTCTransaction( | |||
| const [transactionHash, setTransactionHash] = useState<string | undefined>( | |||
| undefined, | |||
| ) | |||
| const [inProgress, setInProgress] = useState<boolean>(false) | |||
There was a problem hiding this comment.
Maybe it's a good opportunity to refactor this hook and use useMutation hook from @tanstack/react-query?
| onDepositBTCSuccess, | ||
| onDepositBTCError, | ||
| ) | ||
| const { sendBitcoinTransaction, transactionHash, inProgress } = |
There was a problem hiding this comment.
I would rename inProgress to isInProgress to keep consistency with other boolean values. Or if you agree to refactor the useDepositBTCTransaction hook as I mentioned above, we can use status.
| }: { | ||
| step: WalletInteractionStep | ||
| }) { | ||
| const type = useActionFlowType() |
There was a problem hiding this comment.
Suggested change
| const type = useActionFlowType() | |
| const action = useActionFlowType() |
or
Suggested change
| const type = useActionFlowType() | |
| const actionType = useActionFlowType() |
| @@ -25,6 +26,8 @@ export default class OrangeKitTbtcRedeemerProxy implements TbtcRedeemerProxy { | |||
|
|
|||
| #sharesAmount: bigint | |||
|
|
|||
| #builtDataStepCallback?: BuiltDataStepCallback | |||
There was a problem hiding this comment.
Can't we use onSignMessageStepCallback?
| @@ -25,6 +26,8 @@ export default class OrangeKitTbtcRedeemerProxy implements TbtcRedeemerProxy { | |||
|
|
|||
| #sharesAmount: bigint | |||
|
|
|||
| #builtDataStepCallback?: BuiltDataStepCallback | |||
There was a problem hiding this comment.
Maybe we should rename to 🤔 :
Suggested change
| #builtDataStepCallback?: BuiltDataStepCallback | |
| #buildDataStepCallback?: BuiltDataStepCallback |
or
Suggested change
| #builtDataStepCallback?: BuiltDataStepCallback | |
| #dataBuiltStepCallback?: BuiltDataStepCallback |
| @@ -7,6 +7,7 @@ import { OrangeKitSdk } from "@orangekit/sdk" | |||
| import { AcreContracts } from "./contracts" | |||
| import { BitcoinProvider } from "./bitcoin" | |||
|
|
|||
| export type BuiltDataStepCallback = (safeTxData: Hex) => Promise<void> | |||
| isIndeterminate | ||
| {...progressProps} | ||
| /> | ||
| <Image src={connector?.icon} p={2} bg="black" {...ICON_STYLES} /> |
There was a problem hiding this comment.
Let's add alt="Connector icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #811
Closes #814
Closes #813
This PR updates screens for deposit and withdrawal flows. The "Skeleton" loading screen from both Deposit and Withdraw flows is no longer needed. The new flow adds two steps:
Flow:
Screen.Recording.2024-10-31.at.13.12.28.mov