Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a CFStringRef leak in RTMidi Port Name #335

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

baconpaul
Copy link
Contributor

In certain circumstances when building a compound port name (for instance, with an IAC bus), the string math to concatenate the bus and driver does not release one of the source strings, causing a CFStringRef leak on macOS.

This fixes it by doing the appropriate CFRelease after string concatenation.

In certain circumstances when building a compound port name
(for instance, with an IAC bus), the string math to concatenate
the bus and driver does not release one of the source strings,
causing a CFStringRef leak on macOS.

This fixes it by doing the appropriate CFRelease after string
concatenation.
@garyscavone garyscavone merged commit 25b8ab8 into thestk:master Mar 22, 2024
5 checks passed
@baconpaul baconpaul deleted the midi-name-mem-leak branch March 22, 2024 19:54
@baconpaul
Copy link
Contributor Author

Thanks!

Curious if you have a cadence to tag changes. Seems like there’s a few changes since 66.0.0 so wondering if a 6.0.1 might be on the horizon?

appreciate the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants