fix: Update the ecdsa key type to the latest spec (1.0.32). #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
approved these changes
Jun 20, 2023
kommendorkapten
changed the title
The old ecdsa key type is kept to be able to consume older metadata files. Signed-off-by: Fredrik Skogman <[email protected]>
kommendorkapten
force-pushed
the
updated-key-type
branch
from
c3c1a2b to
5cea079
Compare
rdimitrov
changed the title
rdimitrov
changed the title
znewman01
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ecdsa key type is kept to be able to consume older metadata files.
Release Notes:
The go-tuf package now understands the ecdsa key type as specified by The Updateframework specification v1.0.32.
Types of changes:
Description of the changes being introduced by the pull request:
TUF spec v1.0.32 does not specify the
ecdsa-sha2-nistp256key type anymore. Instead the key type isecdsa. See this PR for more details.This fix adds
ecdsaas a known key type, and the default to use when returning the "public data" for a key. The old format (ecdsa-sha2-nistp256) is still recognized as a valid key type.Please verify and check that the pull request fulfills the following requirements: