-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenEdition queryable #434
Conversation
* - `burned = false` | ||
* - `extraData = <Extra data at start of ownership>` | ||
*/ | ||
function explicitOwnershipOf(uint256 tokenId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't really need these. They're nice, but doesn't solve the problem at hand
* @dev Returns an array of `TokenOwnership` structs at `tokenIds` in order. | ||
* See {ERC721AQueryable-explicitOwnershipOf} | ||
*/ | ||
function explicitOwnershipsOf(uint256[] calldata tokenIds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this
* If you are writing GSN compatible contracts, you need to override this function. | ||
*/ | ||
function _msgSenderERC721A() internal view virtual returns (address) { | ||
return msg.sender; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this new? do we need to override this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
updating
No description provided.