Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add elixir-provider #2610

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

JoE11-y
Copy link

@JoE11-y JoE11-y commented Nov 3, 2024

Description

Work to do:

  • Testing
  • Optimization to standard practices.

Pr adding elixir provider to the go-feature-flag

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 9cdd2d6
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/676a6606d392d1000867e03c

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (f12c9a2) to head (9cdd2d6).
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
- Coverage   84.87%   84.77%   -0.11%     
==========================================
  Files         111      111              
  Lines        5178     5207      +29     
==========================================
+ Hits         4395     4414      +19     
- Misses        620      628       +8     
- Partials      163      165       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoE11-y thanks a lot for this pull request, I am super excited to have support for Elixir 😄.

I haven't looked enough yet to be able to provide feedback, but I was wondering if you plan to add any tests for this PR?
Forget about it, I should have read the PR description.

I am really looking forward to complete this PR 🙌 .

@JoE11-y
Copy link
Author

JoE11-y commented Nov 5, 2024

Thank you @thomaspoignant.

Will complete this by today's end 💪

@github-actions github-actions bot added the Stale When an issue is open for too long label Nov 26, 2024
@github-actions github-actions bot removed the Stale When an issue is open for too long label Nov 26, 2024
@thomaspoignant
Copy link
Owner

Hey @JoE11-y do you still want to add the tests or should I look at it myself?

@JoE11-y
Copy link
Author

JoE11-y commented Dec 5, 2024

Hey @JoE11-y do you still want to add the tests or should I look at it myself?

Apologies for the delay, got sidetracked.
I've started adding them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

(feature) OpenFeature Elixir Provider
2 participants