Support file_fixture in Factory definitions
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
commented
Sep 25, 2023
lib/factory_bot_rails/railtie.rb
Outdated
|
|
||
| if defined?(RSpec) | ||
| RSpec.configure do |config| | ||
| if config.respond_to?(:file_fixture_path) |
There was a problem hiding this comment.
Unfortunately, this conditional is always resolving to false, and so the file_fixture_path is never set.
As of [email protected], that setting is available. The current Gemfile.lock that are generated for me locally depends on [email protected], so a hunch tells me that a loading order issue is at the root of the failure.
dorianmariecom
approved these changes
Sep 25, 2023
|
This is our first time extending I can't think of how this could break existing tests but maybe I'm just not being creative enough. |
seanpdoyle
force-pushed
the
file-fixture-path-support
branch
from
8a739aa
to
5a1a15e
Compare
seanpdoyle
force-pushed
the
file-fixture-path-support
branch
5 times, most recently
from
a343bd3
to
0cd66df
Compare
Related to [factory_bot#1282][] [rails/rails#45606][] has been merged and is likely to be released as part of Rails 7.1. With that addition, the path toward resolving [factory_bot#1282][] becomes more clear. If factories can pass along [Pathname][] instances to attachment attributes, Active Support will handle the rest. Instances of `ActiveSupport::TestCase` provide a [file_fixture][] helper to construct a `Pathname` instance based on the path defined by `ActiveSupport::TestCase.file_fixture_path` (relative to the Rails root directory). [factory_bot#1282]: thoughtbot/factory_bot#1282 (comment) [rails/rails#45606]: rails/rails#45606 [Pathname]: https://docs.ruby-lang.org/en/master/Pathname.html [file_fixture]: https://api.rubyonrails.org/classes/ActiveSupport/Testing/FileFixtures.html#method-i-file_fixture
seanpdoyle
force-pushed
the
file-fixture-path-support
branch
from
0cd66df
to
33c1348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to factory_bot#1282
rails/rails#45606 has been merged and is likely to be released as part of Rails 7.1.
With that addition, the path toward resolving factory_bot#1282 becomes more clear. If factories can pass along Pathname instances to attachment attributes, Active Support will handle the rest.
Instances of
ActiveSupport::TestCaseprovide a file_fixture helper to construct aPathnameinstance based on the path defined byActiveSupport::TestCase.file_fixture_path(relative to the Rails root directory).