Validate the number of commitments and signature shares #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of signature shares should at least be equal to the group threshold when aggregating them. We now validate their number to produce a clear error message as soon as possible. Also, the number of commitments and signature shares should be the same so that the produced signature is valid.
lukasz-zimnoch
approved these changes
Oct 1, 2024
In the previous commit, a validation whether the number is not below the threshold was added. After adding the validation whether the number is not higher than the group size, we do a full coverage of the MIN_PARTICIPANTS <= NUM_PARTICIPANTS <= MAX_PARTICIPANTS condition from the FROST paper.
lukasz-zimnoch
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of signature shares should at least be equal to the group threshold when aggregating them. We now validate their number to produce a clear error message as soon as possible. Also, the number of commitments and signature shares should be the same so that the produced signature is valid.