Port keep-network/keep-core/pkg/crypto/ephemeral #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source code of `keep-network/keep-core/pkg/crypto/ephemeral` has been ported to this repository. The ultimate goal is to port the entire GJKR algorithm from `keep-core` repository and parameterize it to work with any ciphersuite. The ephemeral package is a dependency of `gjkr` package so it had to be ported first. To port the `ephemeral` package, I also had to port the box implementation from `keep-network/keep-common/pkg/encryption` package. The box was only used by `ephemeral` so I decided to simplify the code organization and place the box implementation in the `ephemeral` package. This is the only change compared to the original `ephemeral` implementation.
The code ported from the other repository into `ephemeral` package has been adjusted to use `testutils` package for assertions where applicable. This change brings consistency between `ephemeral` and the rest of the code in this repository.
lukasz-zimnoch
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code of
keep-network/keep-core/pkg/crypto/ephemeralhas beenported to this repository. The ultimate goal is to port the entire GJKR
algorithm from
keep-corerepository and parameterize it to work with anyciphersuite. The ephemeral package is a dependency of
gjkrpackage so ithad to be ported first.
To port the
ephemeralpackage, I also had to port the box implementationfrom
keep-network/keep-common/pkg/encryptionpackage. The box was onlyused by
ephemeralso I decided to simplify the code organization and placethe box implementation in the
ephemeralpackage. This is the only changecompared to the original
ephemeralimplementation.In a separate PR, I want to explore if we can use secp256k1 implementation
from
btcsuite/btcd/btcecinstead the one fromethereum/go-ethereumsothat we can avoid importing
ethereum/go-ethereuminto this repository.