Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TACo landing page #113

Merged
merged 21 commits into from
Apr 17, 2024
Merged

Add TACo landing page #113

merged 21 commits into from
Apr 17, 2024

Conversation

evandrosaturnino
Copy link
Contributor

@evandrosaturnino evandrosaturnino commented Mar 19, 2024 •
edited
Loading

Description

Add the TACo landing page to the website with multiple sections - Updated navbar to accommodate a new category for the upcoming Threshold products

Figma's design prototype: https://www.figma.com/file/Zcnn9zVKh9gH1CugLIzpWH/TACo-Page?type=design&node-id=1566%3A625&mode=design&t=mY6QkgaSxFwCqJ9I-1

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • New Feature (Breaking/Non-breaking Change)

Testing

Please outline all testing steps

  1. Clone the repo - git clone https://github.com/threshold-network/website.git
  2. Install dependencies - yarn install
  3. Run the app - yarn start

Screenshots (if applicable)

image

image

image

For mobile:

image

@evandrosaturnino evandrosaturnino self-assigned this Mar 19, 2024
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

1 similar comment
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

arjunhassard
arjunhassard reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Mostly small edits that can be committed directly to the PR

static/images/inference-protection.png Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/templates/build-page/taco/TacoExamples.tsx Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Show resolved Hide resolved
cygnusv
cygnusv reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! First pass with comments on copy.

src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
@evandrosaturnino @arjunhassard @cygnusv
refactor taco landing page copies
6d33a67 
Co-authored-by: Arjun Hassard <[email protected]>
Co-authored-by: David Núñez <[email protected]>
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

derekpierre
derekpierre reviewed Mar 27, 2024
View reviewed changes
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Outdated Show resolved Hide resolved
@evandrosaturnino @derekpierre @arjunhassard
update taco page copies
fbd1071 
Co-authored-by: Derek Pierre <[email protected]>
Co-authored-by: Arjun Hassard <[email protected]>
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

arjunhassard
arjunhassard previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @evandrosaturnino. Let's go with the final copy that is either thumbs-upped or the alternative I've written. Also TACo should sit above the tbtc sdk in the navigation drop down, since it's a fully-fledged infrastructure layer with adopters, and tbtc is already featured prominently elsewhere.

src/content/components/nav-bar.md Outdated Show resolved Hide resolved
src/content/pages/build/taco.md Show resolved Hide resolved
@evandrosaturnino @arjunhassard @derekpierre
update nav bar prioritizing taco over tbtc sdk
7dd9268 
Co-authored-by: Arjun Hassard <[email protected]>
Co-authored-by: Derek Pierre <[email protected]>
@evandrosaturnino
Copy link
Contributor Author

Thanks for all the comments @arjunhassard and @derekpierre.
This PR should be ready for review @michalsmiarowski

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

mhluongo
mhluongo previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@mhluongo mhluongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick nit on casing that we can fix in a follow-up. Looks great y'all

src/content/pages/build/taco.md Outdated Show resolved Hide resolved
@evandrosaturnino
Copy link
Contributor Author

@michalsmiarowski this PR should be ready for review, please! Thank you

@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

@evandrosaturnino @arjunhassard
update taco table description
a030d2f 
Co-authored-by: Arjun Hassard <[email protected]>
@github-actions GitHub Actions
Copy link

Preview uploaded to https://preview.threshold.network/taco-landing-page/index.html.

arjunhassard
arjunhassard approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TACo's long-awaited presence on the Threshold website! Let's keep up the good collaboration @evandrosaturnino

derekpierre
derekpierre approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@cygnusv cygnusv merged commit 22aeea9 into main Apr 17, 2024
3 checks passed
@cygnusv cygnusv deleted the taco-landing-page branch April 17, 2024 09:51
@derekpierre derekpierre mentioned this pull request Apr 19, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunhassard arjunhassard arjunhassard approved these changes

@cygnusv cygnusv cygnusv approved these changes

@derekpierre derekpierre derekpierre approved these changes

@mhluongo mhluongo mhluongo left review comments

@michalsmiarowski michalsmiarowski Awaiting requested review from michalsmiarowski

@michalinacienciala michalinacienciala Awaiting requested review from michalinacienciala

@kpyszkowski kpyszkowski Awaiting requested review from kpyszkowski

@r-czajkowski r-czajkowski Awaiting requested review from r-czajkowski

Assignees

@evandrosaturnino evandrosaturnino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evandrosaturnino @mhluongo @arjunhassard @cygnusv @derekpierre