Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved subbuffer-related functionality from Collector to Buffer #1214

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

MischaPanch
Copy link
Collaborator

@MischaPanch MischaPanch commented Sep 2, 2024

Internal improvements post #1196

@maxhuettenrauch FYI

@Trinkle23897 I'm going to merge this directly after CI runs through as it's small internal improvements in new functionality, which are well tested and documented inside the codebase, no need for review IMO.

Overall improvements in documentation will follow soon

Michael Panchenko added 2 commits September 2, 2024 18:50
Added several tests for the new functionality
Also better names, documentation and input-validation in ReplayBuffer.add
@MischaPanch MischaPanch merged commit 16f2fc2 into master Sep 2, 2024
4 checks passed
@MischaPanch MischaPanch deleted the refactoring/buffer-collector-indexing branch September 2, 2024 17:42
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (7640c6e) to head (c903f72).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
tianshou/data/buffer/base.py 85.36% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   85.30%   85.28%   -0.03%     
==========================================
  Files         102      102              
  Lines        9074     9078       +4     
==========================================
+ Hits         7741     7742       +1     
- Misses       1333     1336       +3     
Flag Coverage Δ
unittests 85.28% <86.95%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants