Fedora 39 Build Fixes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See failed build here: https://github.com/tianocore/containers/actions/runs/7139961213/job/19444323214#step:5:70 |
Specifying version numbers for the packages provided by the Linux distribution is counterproductive. The available patchlevel versions of a package can change within a Fedora release. This can breaks image builds which requires additional manual work. Since the major versions stay fixed, there should not be any compatibility issues between image builds. Additionally, bug fixes are picked up automatically. This patch removes the explicit version numbers from the packages and installs the default versions instead. Signed-off-by: Oliver Steffen <[email protected]>
Install python-setuptools via pip instead of taking it from the Fedora repo. This avoids possible conflicts with `pip install --upgrade ...` Signed-off-by: Oliver Steffen <[email protected]>
osteffenrh
force-pushed
the
fixup-f39-2
branch
from
e49d659
to
c98f63e
Compare
makubacki
reviewed
Dec 8, 2023
I agree with this. |
makubacki
approved these changes
Dec 8, 2023
mairudiF
added a commit
to mairudiF/containers
that referenced
this pull request
Mar 2, 2024
* Add Fedora 39 image with gcc13 (tianocore#82) Added Fedora 39 base image, providing GCC13 and Python 3.12. Signed-off-by: Chao Li <[email protected]> * Fedora 39 fixups (tianocore#87) * Fedora 39: Use Qemu from package repo Fedora 39 ships Qemu 8. We can use that instead of building it from source. Also add Qemu for RiscV. Signed-off-by: Oliver Steffen <[email protected]> * Allow using dev image as root Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. See issue tianocore#76 and PR tianocore#77. Signed-off-by: Oliver Steffen <[email protected]> * Readme: Add Fedora 39 image to table Add links and badges for the Fedora 39 images to the table. Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Oliver Steffen <[email protected]> * Fedora 39 Build Fixes (tianocore#88) * Fedora39: Don't use fixed package versions Specifying version numbers for the packages provided by the Linux distribution is counterproductive. The available patchlevel versions of a package can change within a Fedora release. This can breaks image builds which requires additional manual work. Since the major versions stay fixed, there should not be any compatibility issues between image builds. Additionally, bug fixes are picked up automatically. This patch removes the explicit version numbers from the packages and installs the default versions instead. Signed-off-by: Oliver Steffen <[email protected]> * Fedora 39: Install python-setuptools via pip Install python-setuptools via pip instead of taking it from the Fedora repo. This avoids possible conflicts with `pip install --upgrade ...` Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Chao Li <[email protected]> Signed-off-by: Oliver Steffen <[email protected]> Co-authored-by: Chao Li <[email protected]> Co-authored-by: Oliver Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fedora 39 image build is failing due to changes in the patchlevel version of the available gcc packages. The Dockerfile currently specifies the exact version numbers, which need to be updated manually.
Also: It is better to install the Python setuptools via pip instead from Fedora, to avoid conflicts with
pip install --upgrade ...later.These changes make the image easier to maintain.
Containers Affected
Fedora 39