Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create macro params for oscillators #1181

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions packages/core/controls.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,49 @@ export function registerControl(names, ...aliases) {
*/
export const { s, sound } = registerControl(['s', 'n', 'gain'], 'sound');

/**
* generic macro param for a sound synth
*
* @name z1
* @synonyms z
* @param {number | Pattern}
* @example
* n(run(8)).scale("D:pentatonic").s("supersaw").x(".01 .75").release(0.5)
*
*/
export const { z1, z } = registerControl(['z1', 'z2', 'z3', 'z4'], 'z');

/**
* generic macro param for a sound synth
*
* @name z2
* @param {number | Pattern}
* @example
* n(run(8)).scale("D:pentatonic").s("supersaw").x2("2 .7").release(0.5)
*
*/
export const { z2 } = registerControl('z2');

/**
* generic macro param for a sound synth
*
* @name z3
* @param {number | Pattern}
* @example
* n(run(8)).scale("D:pentatonic").s("supersaw").x3(".1 .75").release(0.5)
*
*/
export const { z4 } = registerControl('z3');

/**
* generic macro param for a sound synth
*
* @name x4
* @param {number | Pattern}
*
*/
export const { x4 } = registerControl('z4');
daslyfe marked this conversation as resolved.
Show resolved Hide resolved

/**
* Define a custom webaudio node to use as a sound source.
*
Expand Down
5 changes: 3 additions & 2 deletions packages/superdough/synth.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ export function registerSynthSounds() {
'supersaw',
(begin, value, onended) => {
const ac = getAudioContext();
let { duration, n, unison = 5, spread = 0.6, detune } = value;
detune = detune ?? n ?? 0.18;
const {z1, z2, z3} = value;
let { duration, n, unison = z2 ?? 5, spread = z3 ?? 0.6, detune, } = value;
detune = detune ?? n ?? z1 ?? 0.18;
const frequency = getFrequencyFromValue(value);

const [attack, decay, sustain, release] = getADSRValues(
Expand Down
Loading