Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pregain + move postgain after sends #904

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

felixroos
Copy link
Collaborator

the postgain control was a bit misleading, as it was still applied before the effect sends. this PR adds another gain stage called pregain be the gain stage before the effect sends (but after local effects). Additionally, if a value is set to postgain, another gain stage will be added at the very end. this should allow full wet effects in the future. The signal path is now:

source -> gain -> local fx -> pregain -> sends -> postgain

@daslyfe
Copy link
Collaborator

daslyfe commented Feb 22, 2024

I wonder if it would be possible to evaluate the fx and chain them in the order they are written also, then you might not even need all three gain types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants