Merge pull request #161 from Jakub-Krakowiak/feature/rgl-reduce-garba…

…ge-collection Performance increase for RGLUnityPlugin by reducing garbage collection
tier4 · Jul 31, 2023 · fdbb880 · fdbb880
2 parents 3bfd988 + b6647b7
commit fdbb880
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/Assets/RGLUnityPlugin/Scripts/SceneManager.cs b/Assets/RGLUnityPlugin/Scripts/SceneManager.cs
@@ -138,9 +138,8 @@ public void DoUpdate()
             SynchronizeSceneTime();
 
             Profiler.BeginSample("Find changes and make TODO list");
-            var thisFrameGOs = FindObjectsOfType<GameObject>()
-                .Where(go => go.activeInHierarchy)
-                .Where(go => go.GetComponentsInParent<LidarSensor>().Length == 0);
+            var thisFrameGOs = new HashSet<GameObject>(FindObjectsOfType<GameObject>());
+            thisFrameGOs.RemoveWhere(IsNotActiveOrParentHasLidar);
 
             // Added
             var toAddGOs = new HashSet<GameObject>(thisFrameGOs);
@@ -160,7 +159,7 @@ public void DoUpdate()
                 .Except(toRemove).ToArray();
             RGLObject[] toSkin = existingToSkin.Concat(newToSkin).ToArray();
 
-            lastFrameGameObjects = new HashSet<GameObject>(thisFrameGOs);
+            lastFrameGameObjects = thisFrameGOs;
             Profiler.EndSample();
 
             Profiler.BeginSample("Add new textures");
@@ -548,5 +547,10 @@ private static void AddTextures(IEnumerable<RGLObject> rglObjects)
                 sharedTexturesUsageCount[textureID] += 1;
             }
         }
+
+        private static bool IsNotActiveOrParentHasLidar(GameObject gameObject)
+        {
+            return !gameObject.activeInHierarchy || gameObject.GetComponentsInParent<LidarSensor>().Length != 0;
+        }
     }
 }