Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(odometry_sensor): add ground truth odometry to Unity scene #178

Merged
merged 6 commits into from
Aug 10, 2023
Merged

feat(odometry_sensor): add ground truth odometry to Unity scene #178

merged 6 commits into from
Aug 10, 2023

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 9, 2023 •
edited
Loading

This PR resolve #177

tested with main scene
image

SakodaShintaro
SakodaShintaro approved these changes Aug 9, 2023
View reviewed changes
Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the build & execution is successful in this branch.
The target topic, /awsim/ground_truth/localization/kinematic_state, was also flowing properly.

Thank you very much!

mackierx111
mackierx111 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! LGTM

@mackierx111 mackierx111 merged commit 7c4d908 into main Aug 10, 2023
2 checks passed
@mackierx111 mackierx111 deleted the feature/add_odometry_sensor branch August 10, 2023 01:25
@mackierx111 mackierx111 mentioned this pull request Aug 10, 2023
Closed
2 tasks
@taikitanaka3 taikitanaka3 mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWSIM outputs Localization
3 participants
@taikitanaka3 @mackierx111 @SakodaShintaro