-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detection_area)!: sync latest feature #1631
base: beta/v0.3.20
Are you sure you want to change the base?
Conversation
Please add the following to 'How was this PR tested?' section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuki-takagi-66
Please change the base branch from beta/v0.3.19 to beta/v0.3.20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link your internal JIRA managed tickets to maintain traceability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is difficult to understand what specific changes are being referred to by "sync latest feature", please set a PR title that mentions the specific feature.
Signed-off-by: Yuki Takagi <[email protected]>
db407e1
to
b7f9c8c
Compare
The basic design document clearly states that "please consider the detailed design," but this PR makes no mention of the detailed design. Or, if you have decided that implementing it as per the basic design document is fine, please state that in the Description field. |
Quality Gate passedIssues Measures |
Please justify all changes in the PR (show that the changes are necessary and sufficient). In the "Description" field, clearly list the features and clarify how they correspond to the implementation. |
In the "How was this PR tested?" field, please include not only the URL, but also a summary of the results and your judgement as the PR submitter as to whether the changes to this PR are appropriate. |
Description
This PR suppress abort behavior after departing the stop line
This PR is hand-made cherry-pick of the following PRs.
autowarefoundation#3114
autowarefoundation#9255
Related links
Parent Issue:
How was this PR tested?
Test criteria: https://docs.google.com/presentation/d/1_OSWKhMmRUf1QYhQGOVd9jnOLOWl8S7rGE-5VcO04zk/edit#slide=id.g315595f3e6d_0_12942
Test results: https://tier4.atlassian.net/browse/AEAP-1903?focusedCommentId=194502
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.