Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #765

Merged
merged 17 commits into from
Aug 24, 2023
Merged

chore: sync upstream #765

merged 17 commits into from
Aug 24, 2023

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Bug Fixes

Code Refactoring

Performance Improvements

Tests

YoshiRi and others added 17 commits August 23, 2023 01:26
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ction.launch.xml (autowarefoundation#4596)

* Update lidar_based_detection.launch.xml

Some launch arguments were missing. These arguments and their defaults were added.

Signed-off-by: Alireza Moayyedi <[email protected]>

* changed default of objects_filter_method

changed default of the "objects_filter_method" to "lanelet_filter" as requested.

Signed-off-by: Alireza Moayyedi <[email protected]>

---------

Signed-off-by: Alireza Moayyedi <[email protected]>
autowarefoundation#4599)

* feat(vehicle_cmd_gate): variable filter limits for different vehicle speed

Signed-off-by: Takamasa Horibe <[email protected]>

* add steer diff test

Signed-off-by: Takamasa Horibe <[email protected]>

* add node test for vehicle_cmd_gate

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* add is_filter_activated msg

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* update is_activate for each field

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* Update control/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp

* add function test for interpolation

Signed-off-by: Takamasa Horibe <[email protected]>

* fix format

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused file

Signed-off-by: Takamasa Horibe <[email protected]>

* add missing depend

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
…on's declaration (autowarefoundation#4645)

* refactor(freespace_planning_algorithms): delete default values of function declare_parameter

* refactor(freespace_planning_algorithms): fix way to call declare_parameter function and add config repository.

* refactor(freespace_planning_algorithms): fix way to declare declare_parameter function

* fix(freespace_planner): add parameters for RRTStar search algorithm

* style(pre-commit): autofix

* refactor(freespace_planner): undo the change of planning algorithm

---------

Signed-off-by: keiota <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kyoichi Sugahara <[email protected]>
…okupTransform exception in util function (autowarefoundation#4713)

* add lookupTransform exception in util function and add launch_test

Signed-off-by: yoshiri <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…chardJP's work) (autowarefoundation#4185)

* perf(ring_outlier_filter): a cache friendly impl

Signed-off-by: Vincent Richard <[email protected]>

style(pre-commit): autofix

fix(ring_outlier_filter): cleanup code with ranges

Signed-off-by: Vincent Richard <[email protected]>

[breaking] fix autoware point type padding for faster memory access

can memcpy between input data buffer and PointXYZI*
make assumption on memory layout for faster data fetch
misc optimization (reordering, constexpr, etc)

Signed-off-by: Vincent Richard <[email protected]>

style(pre-commit): autofix

comment limitations

Signed-off-by: Vincent Richard <[email protected]>

feat(ring_outlier_filter): add accurate isCluster impl

Signed-off-by: Vincent Richard <[email protected]>

style(pre-commit): autofix

fix autowarefoundation#3218

Signed-off-by: Vincent Richard <[email protected]>

cleaning

Signed-off-by: Vincent Richard <[email protected]>

style(pre-commit): autofix

* style(pre-commit): autofix

* resize vector to data size

Signed-off-by: Vincent Richard <[email protected]>

* cleaning

Signed-off-by: Vincent Richard <[email protected]>

* cleaner utilities impl

Signed-off-by: Vincent Richard <[email protected]>

* Correct ring_outlier_filter algorithm

The implementation by VRichardJP was erroneously using indices into the
input->fields array as byte offsets for copying values from the input.
Added the missing step to access the offset of the field pointed at by
the respective index.

When combining the first and last walk, the num_points fields of the two
walks need to be summed up as well. isCluster checks for num_points
as well as distance.

Signed-off-by: Maximilian Schmeller <[email protected]>

* Optimize memory usage of walks array

The walks array in the previous implementation could in the worst case grow
to the number of input points (if every point is an outlier).
This increased computation time for gradually growing the walks vector.

The current implementation only saves the first and current walk for
every ring. The isCluster check is performed right when a walk is
completed, and a bool vector akin to the previous walk_is_cluster
vector is maintained.

Signed-off-by: Maximilian Schmeller <[email protected]>

* Remove debug timers and outputs

Signed-off-by: Maximilian Schmeller <[email protected]>

* style(pre-commit): autofix

* Reduce amount of helper functions and data structures

Remove functions for finding field offsets of Pointcloud2 points,
replace them with the previous approach of assuming their position.
This is okay since the ring_outlier_filter specification clearly states
the expected pointcloud format.

Remove accessor lambda functions for ring/azimuth/etc. because they are
onlu used once anyways.

Remove the walks vector and save the first/current walk structs directly
in the RingWalkInfo struct. This makes the code more readable and
maintainable.

Signed-off-by: Maximilian Schmeller <[email protected]>

* style(pre-commit): autofix

* Check for invalid pointcloud format

In the previous revision (and before this PR), pointcloud field indices
in ring_outlier_filter were hardcoded and fields were assumed to exist.

VRichardJP solved this by implementing individual accessor functions,
which ended up to be a bit verbose for this small piece of
functionality.

Now, there is one generic accessor function and the faster_filter
function exits if any of the fields expected does not exist.
The expected field data type is also checked.

Signed-off-by: Maximilian Schmeller <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Vincent Richard <[email protected]>
Signed-off-by: Maximilian Schmeller <[email protected]>
Co-authored-by: Vincent Richard <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maximilian Schmeller <[email protected]>
* feat(map_projection_loader, map_loader): rename utm to local_cartesian_utm

Signed-off-by: kminoda <[email protected]>

* fix readme

Signed-off-by: kminoda <[email protected]>

* fix default ad api

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
… predicted path generation (autowarefoundation#4669)

* add_pull_out_member_variables

Signed-off-by: kyoichi-sugahara <[email protected]>

* update pull_out path struct

Signed-off-by: kyoichi-sugahara <[email protected]>

* update pull_out path struct

Signed-off-by: kyoichi-sugahara <[email protected]>

* minor update

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix calculation

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix build error

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix code

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix code

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
* feat(gnss_poser): remove plane coordinate

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* remove geo_pos_conv

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tion#4702)

* feat(gnss_poser): remove UTM projection in gnss_poser

Signed-off-by: kminoda <[email protected]>

* update readme

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* remove coordinate_system from GNSSStat

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…dation#4643)

* test(traffic_light_utils): add test_traffic_light_utils

Signed-off-by: beginningfan <[email protected]>

* style(pre-commit): autofix

* fix(traffic_light_utils): fix magic number

Signed-off-by: beginningfan <[email protected]>

* style(pre-commit): autofix

* fix(traffic_light_utils): fix namespace cpplint

Signed-off-by: beginningfan <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: beginningfan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(utils): fix longitudinal length inconsistency

Signed-off-by: satoshi-ota <[email protected]>

* fix(utils): improve logic

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
…ion#4714)

* feat(glog): add glog component

Signed-off-by: Takamasa Horibe <[email protected]>

* formatting

Signed-off-by: Takamasa Horibe <[email protected]>

* remove namespace

Signed-off-by: Takamasa Horibe <[email protected]>

* remove license

Signed-off-by: Takamasa Horibe <[email protected]>

* Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/motion_planning/motion_planning.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update common/glog_component/CMakeLists.txt

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* Update launch/tier4_control_launch/launch/control.launch.py

Co-authored-by: Daisuke Nishimatsu <[email protected]>

* add copyright

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
…warefoundation#4720)

* feat(obstacle_cruise_planner): add a hold stop distance feature

Signed-off-by: Takayuki Murooka <[email protected]>

* add param

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants