forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): cherry-pick LC PRs #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakaHoribe
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
October 13, 2023 12:07
TakaHoribe
changed the title
fix(lane_change): add guard to neigibor lanelets (#5245)
feat(lane_change): cherry-pick LC PRs
Oct 13, 2023
TakaHoribe
force-pushed
the
lc-update-20231013
branch
2 times, most recently
from
October 15, 2023 08:37
861c84e
to
2269473
Compare
…5245) Signed-off-by: kosuke55 <[email protected]>
…en the ego is in stuck (autowarefoundation#5249) * [lane_change] sampling all possible longitudinal acceleration when the ego is in stuck Signed-off-by: Takamasa Horibe <[email protected]> * add clock Signed-off-by: Takamasa Horibe <[email protected]> * update Signed-off-by: Takamasa Horibe <[email protected]> * Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp Co-authored-by: Zulfaqar Azmi <[email protected]> * Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp Co-authored-by: Fumiya Watanabe <[email protected]> * Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp Co-authored-by: Fumiya Watanabe <[email protected]> * fix style Signed-off-by: Takamasa Horibe <[email protected]> --------- Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]>
…autowarefoundation#5236) * feat(lane_change): keep distance against avoidable stationary objects Signed-off-by: kosuke55 <[email protected]> consider rss distance Signed-off-by: kosuke55 <[email protected]> tmp Signed-off-by: kosuke55 <[email protected]> * fix dangling Signed-off-by: Takamasa Horibe <[email protected]> * use parameter for velocity_treshold Signed-off-by: Takamasa Horibe <[email protected]> * check object only on the ego path Signed-off-by: Takamasa Horibe <[email protected]> * fix Signed-off-by: Takamasa Horibe <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]>
) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…efoundation#5287) Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 <[email protected]> Update planning/behavior_path_planner/src/utils/path_safety_checker/safety_check.cpp fix(path_safety_checker): remove redundant parameter name Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]> use margin Signed-off-by: Takamasa Horibe <[email protected]>
…ndation#5296) fix(lane_change): target lane blocking condition remove in_terminal condition fix Signed-off-by: Takamasa Horibe <[email protected]>
TakaHoribe
force-pushed
the
lc-update-20231013
branch
from
October 15, 2023 18:14
027567c
to
63993a7
Compare
Signed-off-by: Takamasa Horibe <[email protected]> update Signed-off-by: Takamasa Horibe <[email protected]>
TakaHoribe
force-pushed
the
lc-update-20231013
branch
from
October 15, 2023 18:25
e58d1d5
to
951af6c
Compare
…utowarefoundation#5299) Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
…in chattering Signed-off-by: kosuke55 <[email protected]> use boost intersects Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
lc-update-20231013
branch
from
October 16, 2023 08:38
8024d6d
to
29af126
Compare
…arefoundation#5318) * fix(lane_change): do not use refelence values of polygon outer Signed-off-by: Fumiya Watanabe <[email protected]> * fix(lane_change): fix in lane change Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
takayuki5168
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LC改善のcherry-picks
polygon.outer()
の参照を使わないようにする fix(lane_change): do not use reference values of polygon outer autowarefoundation/autoware.universe#5318This PR should be tested with https://github.com/tier4/autoware_launch.x2/tree/lc-update-20231013 branch which contains
Tests performed
https://tier4.atlassian.net/wiki/spaces/~793737791/pages/2909798824/LC#%E5%AE%A4%E5%B2%A1%E3%81%8F%E3%82%93%E3%81%8B%E3%82%89%E3%81%AE%E8%A6%81%E6%B1%82
876b3bb3-9151-4c09-900c-7e9ce41cda6d.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.