-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(faq): how to record applications that include RelayNode #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Documentation URL: https://tier4.github.io/caret_doc/pr-309/ |
ymski
changed the title
docs(faq): add known issue for ReleyNode
docs(faq): How to record applications that include RelayNode
Nov 13, 2023
ymski
changed the title
docs(faq): How to record applications that include RelayNode
docs(faq): how to record applications that include RelayNode
Nov 13, 2023
Signed-off-by: ymski <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
isp-uetsuki
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a method to record applications that use RelayNode.
RelayNode use GenericPublisher, GenericSubscription which doesn't have necessary trace point for evaluation with CARET.
To record the application containing the RelayNode, it is necessary to rebuild the RelayNode using caret-rclcpp.
Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.