Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): how to record applications that include RelayNode #309

Merged
merged 16 commits into from
Nov 22, 2023

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Nov 13, 2023

Description

Added a method to record applications that use RelayNode.
RelayNode use GenericPublisher, GenericSubscription which doesn't have necessary trace point for evaluation with CARET.
To record the application containing the RelayNode, it is necessary to rebuild the RelayNode using caret-rclcpp.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ymski ymski added deploy-docs tag:deploy-docs deploy documentation as testing labels Nov 13, 2023
Copy link

@ymski ymski changed the title docs(faq): add known issue for ReleyNode docs(faq): How to record applications that include RelayNode Nov 13, 2023
@ymski ymski changed the title docs(faq): How to record applications that include RelayNode docs(faq): how to record applications that include RelayNode Nov 13, 2023
ymski and others added 4 commits November 17, 2023 19:01
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski merged commit cd17f8c into tier4:main Nov 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-docs tag:deploy-docs deploy documentation as testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants