Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update xml version #258

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

h-suzuki-isp
Copy link
Contributor

@h-suzuki-isp h-suzuki-isp commented Dec 15, 2023

Description

Because there was no upgrade in package.xml version tag, update to 0.4.22 for rosdistro review.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44ba286) 25.02% compared to head (ea782c6) 36.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #258       +/-   ##
===========================================
+ Coverage   25.02%   36.63%   +11.61%     
===========================================
  Files          58       28       -30     
  Lines        3321     2061     -1260     
  Branches     1085     1068       -17     
===========================================
- Hits          831      755       -76     
+ Misses       1756      576     -1180     
+ Partials      734      730        -4     
Flag Coverage Δ
differential 36.63% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-suzuki-isp h-suzuki-isp changed the title refactor: upgrade xml version chore: update xml version Dec 15, 2023
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-suzuki-isp h-suzuki-isp merged commit 15f8f7e into tier4:main Dec 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants