Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node filter improvement #280

Merged
merged 49 commits into from
Apr 25, 2024
Merged

fix: node filter improvement #280

merged 49 commits into from
Apr 25, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Apr 12, 2024

Description

Add filtering where node and topic filters are missing.
In adding the processing, we will address problems with the conventional filter processing and duplicate address issues.

Related links

https://tier4.atlassian.net/browse/RT2-844
https://tier4.atlassian.net/browse/RT2-200
https://tier4.atlassian.net/browse/RT2-1060
https://tier4.atlassian.net/browse/RT2-1469

Notes for reviewers

  • The next trace point is always output since the node cannot be identified due to the order of occurrence. (iron)
    • rclcpp_ipb_to_subscription
    • rclcpp_buffer_to_ipb
    • rclcpp_construct_ring_buffer
  • "message_construct" Tracepoints are output in humble, but not in iron.
  • "dds_bind_addr_to_stamp" trace point by generic_publish() is output after jazzy.
  • The "rclcpp_ring_buffer_clear" trace point is not output by ros2 in its current state.
  • Addressed a problem that "construct_static_executor" tracepoints are not output correctly when measuring from the middle of a measurement. (RT2-1469)

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

xygyo77 and others added 27 commits March 6, 2024 18:25
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
…map() should be of type rclcpp::node_interfaces::NodeBaseInterface::SharedPtr and the argument of orig_func() should also be The argument of orig_func() should be the same type.

Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
@xygyo77 xygyo77 requested a review from ymski April 12, 2024 14:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 17.00000% with 249 lines in your changes are missing coverage. Please review.

Project coverage is 53.54%. Comparing base (75e1c3f) to head (9916bc3).
Report is 10 commits behind head on main.

Files Patch % Lines
CARET_trace/src/tracing_controller.cpp 16.07% 203 Missing and 11 partials ⚠️
CARET_trace/src/ros_trace_points.cpp 19.23% 15 Missing and 6 partials ⚠️
CARET_trace/src/hooked_trace_points.cpp 26.31% 8 Missing and 6 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #280       +/-   ##
===========================================
+ Coverage   25.02%   53.54%   +28.52%     
===========================================
  Files          58       28       -30     
  Lines        3321     2144     -1177     
  Branches     1085     1183       +98     
===========================================
+ Hits          831     1148      +317     
+ Misses       1756      732     -1024     
+ Partials      734      264      -470     
Flag Coverage Δ
differential 53.54% <17.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xygyo77 xygyo77 self-assigned this Apr 14, 2024
CARET_trace/src/ros_trace_points.cpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/data_container.hpp Outdated Show resolved Hide resolved
CARET_trace/src/hooked_trace_points.cpp Outdated Show resolved Hide resolved
CARET_trace/src/tracing_controller.cpp Outdated Show resolved Hide resolved
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/src/tracing_controller.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[compare] ========== Result ==========
[compare] 1/3 file existence matches
[compare] OK. file existence matches
[compare] 2/3 yaml files
[compare] OK. yaml matches
[compare] 3/3 PNG files
[compare] OK. PNG matches
[compare] ====== ALL OK ==============

@xygyo77 xygyo77 merged commit 27302e7 into tier4:main Apr 25, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants