feat: jazzy support #306
Open
feat: jazzy support #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymski
requested changes
Oct 29, 2024
| return; | ||
| } | ||
|
|
||
| if (trace_filter_is_rcl_publish_recorded) { |
There was a problem hiding this comment.
The following is one of the suggestions for implementation improvement.
I don't think it's necessary to include this in the current PR, but I'll leave it as text for reference.
Until now, we've been determining whether to apply the filter for rmw_publish (=dds_write) based on the presence or absence of rcl_publish records.
However, from jazzy onwards, we can obtain rmw_publish.
Using rmw_publish for filtering might enable a more appropriate implementation.
There was a problem hiding this comment.
no particular corrections made to this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jazzy support
Related links
https://tier4.atlassian.net/browse/RT2-1803
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.