Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add message_construct tracepoint on light mode instrumentation. #187

Merged

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented May 9, 2024

Description

Add “message_construct” to the target trace point of light mode measurement.

Related links

https://tier4.atlassian.net/browse/RT2-1555

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski May 9, 2024 05:44
@xygyo77 xygyo77 changed the title add message_construct tracepoint on light mode instrumentation. feat: add message_construct tracepoint on light mode instrumentation. May 9, 2024
@ymski
Copy link
Contributor

ymski commented May 10, 2024

The code looks good.

@ymski ymski requested a review from miyakoshi-dev May 10, 2024 02:14
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit 4c54383 into tier4:main May 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants