Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total number of processes becomes None #193

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

miyakoshi-dev
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev commented Jul 2, 2024

Description

When using the -v option during measurement in a multi-host environment, the total number of processes to be measured becomes None.

Related links

https://tier4.atlassian.net/browse/RT2-1593

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@miyakoshi-dev miyakoshi-dev requested a review from ymski July 2, 2024 02:29
ros2caret/verb/record.py Outdated Show resolved Hide resolved
@miyakoshi-dev miyakoshi-dev requested a review from ymski July 9, 2024 02:53
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. LGTM.

@miyakoshi-dev miyakoshi-dev merged commit 1ee3eff into tier4:main Jul 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants