Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2124: Moving third-party licenses to static hosting for OSS #1367

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

ctauchen
Copy link
Collaborator

No description provided.

@ctauchen ctauchen requested a review from a team as a code owner March 12, 2024 11:24
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1531b21
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65f1cb0e98a9a10008fbee19
😎 Deploy Preview https://deploy-preview-1367--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 1531b21
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65f1cb0e0db12e0009a1df63
😎 Deploy Preview https://deploy-preview-1367--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 7 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator Author

@ronanc-tigera I'm getting some strange behavior on this one. I'm changing these large license files so that they're just static html in our static directory. I've changed the sidebars to link to the URL. But when you click on the link from the sidebars (in Reference/Attributions), it returns a 404. But then, if you refresh the page, the correct licenses page loads just fine.

Is this something you've seen before? The only thing I can think of at this point is to use the full URL (https://docs.tigera.io/...) and merge, hope that that resolves. Not at all sure why it would.

@ctauchen ctauchen force-pushed the docs-2124-fossa-static branch 2 times, most recently from 671d4b2 to 82824b7 Compare March 13, 2024 15:37
@ctauchen ctauchen merged commit 37079cc into tigera:main Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant