Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPF docs - Add a note about IPVS and MKE docs to 3.28 #1634

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

sridhartigera
Copy link
Contributor

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 6e8a4c2
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/670e6c2613c4cd000864b1b5
😎 Deploy Preview https://deploy-preview-1634--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 37 (🟢 up 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e8a4c2
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/670e6c2608a4b6000864fa3c
😎 Deploy Preview https://deploy-preview-1634--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🟢 up 23 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sridhartigera sridhartigera changed the title Fix bpf EE docs and add a limitation. Fix bpf EE docs Sep 4, 2024
@sridhartigera sridhartigera changed the title Fix bpf EE docs BPF docs - Add a note about IPVS Sep 4, 2024
@sridhartigera sridhartigera marked this pull request as ready for review September 4, 2024 21:16
@sridhartigera sridhartigera requested a review from a team as a code owner September 4, 2024 21:16
@@ -161,6 +161,11 @@ To re-enable it:
```bash
kubectl patch networks.operator.openshift.io cluster --type merge -p '{"spec":{"deployKubeProxy": true}}'
```
:::note

If you are running kube-proxy in IPVS mode, switch to IPTables mode before disabling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, switch IPTable to iptables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be part of ### Configure kube-proxy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its part of configure kube-proxy section.

@ctauchen
Copy link
Collaborator

@sridhartigera Can you provide some context here? Links to tickets, say?

@sridhartigera
Copy link
Contributor Author

@sridhartigera Can you provide some context here? Links to tickets, say?

@ctauchen we don't support migrating from IPVS mode to eBPF dataplane. We have seen few users trying this. Hence it will be better to call this out explicitly.

@sridhartigera sridhartigera changed the title BPF docs - Add a note about IPVS BPF docs - Add a note about IPVS and MKE docs to 3.28 Oct 11, 2024
@@ -42,6 +42,7 @@ and in particular, pushing the networking capabilities of the latest Linux kerne
**Unsupported platforms**

- GKE
- MKE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing support for MKE, do we not need to remove from other areas? See Line 170 in enabling-ebpf.mdx. I can't make any sense of this. If there's a qualification, this must be made explicit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. That was a mistake. we are not removing support for MKE. Reverted ^^

@ctauchen ctauchen merged commit ae61dcb into tigera:main Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants