Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing create service step for typha metrics #1706

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

vikastigera
Copy link
Contributor

@vikastigera vikastigera commented Oct 7, 2024

Changes done to remove create service step
for typha prometheus, as this step is already
automated through code.

Product Version(s):

Issue:
https://tigera.atlassian.net/browse/EV-5195

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Changes done to remove create service step
for typha prometheus, as this step is already
automated through code.
@vikastigera vikastigera requested a review from a team as a code owner October 7, 2024 17:19
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 1fc509e
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6704181cb174af000897648a
😎 Deploy Preview https://deploy-preview-1706--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 38 (🔴 down 7 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1fc509e
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/6704181ba30cae0008916749
😎 Deploy Preview https://deploy-preview-1706--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🟢 up 23 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker rene-dekker merged commit 48ae7ef into tigera:main Oct 7, 2024
10 checks passed
@vikastigera vikastigera deleted the EV-5195 branch October 7, 2024 18:04
vikastigera added a commit to vikastigera/docs that referenced this pull request Oct 15, 2024
Changes done to remove create service step
for typha prometheus, as this step is already
automated through code. (These changes were done as part
of tigera#1706)
ctauchen pushed a commit that referenced this pull request Oct 17, 2024
Changes done to remove create service step
for typha prometheus, as this step is already
automated through code. (These changes were done as part
of #1706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants