Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS-2108] Clarify DPI alerts are in alerts page #1728

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

gantony
Copy link
Contributor

@gantony gantony commented Oct 21, 2024

This PR updates the docs to reference that DPI alerts are shown in the alerts page. This was wrong in the 3.19 version, and was planned for 3.20 EP2, but that change is no longer happening.

Product Version(s):

Issue:
https://tigera.atlassian.net/browse/RS-2108

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@gantony gantony requested a review from a team as a code owner October 21, 2024 12:37
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit f97a670
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67164b5c2529fa0008f417c3
😎 Deploy Preview https://deploy-preview-1728--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 55 (🟢 up 28 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit f97a670
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67164b5c7560780008efcc47
😎 Deploy Preview https://deploy-preview-1728--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator

LGTM, pending clean build. Are you ready for a merge? @gantony

@gantony
Copy link
Contributor Author

gantony commented Oct 21, 2024

LGTM, pending clean build. Are you ready for a merge? @gantony

Yes, I have no more changes to add. Please feel free to merge whenever you can.

@ctauchen ctauchen merged commit f803e9d into tigera:main Oct 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants