Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in kernel dependencies page #1738

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

hjiawei
Copy link
Contributor

@hjiawei hjiawei commented Oct 25, 2024

This change fixes spacing in the kernel dependencies page and reformat README.md.

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@hjiawei hjiawei requested a review from a team as a code owner October 25, 2024 15:47
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit b3496fe
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/672110a447d39a000825871b
😎 Deploy Preview https://deploy-preview-1738--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🟢 up 7 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3496fe
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/672110a452b38e000723edc1
😎 Deploy Preview https://deploy-preview-1738--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🔴 down 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. One small adjustment, otherwise LGTM.

README.md Outdated Show resolved Hide resolved
@ctauchen
Copy link
Collaborator

LGTM, pending rebase to resolve merge conflict.

This change fixes spacing in the kernel dependencies page
and reformat README.md.
@hjiawei
Copy link
Contributor Author

hjiawei commented Oct 29, 2024

LGTM, pending rebase to resolve merge conflict.

Rebased and conflicts are resolved.

@ctauchen ctauchen merged commit 84df617 into tigera:main Oct 29, 2024
10 checks passed
@hjiawei hjiawei deleted the fix-req-kernel-spacing branch October 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants