Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calicoctl resource list docs #1743

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

caseydavenport
Copy link
Member

Product Version(s):

Issue:

Documents this PR: projectcalico/calico#9054

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@caseydavenport caseydavenport requested a review from a team as a code owner October 28, 2024 18:27
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 46904c9
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/671fd79ca2b9f800088d650a
😎 Deploy Preview https://deploy-preview-1743--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 41 (🟢 up 9 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 46904c9
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/671fd79c0c075a0008e8c444
😎 Deploy Preview https://deploy-preview-1743--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🟢 up 10 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@coutinhop coutinhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caseydavenport !

@ctauchen
Copy link
Collaborator

@caseydavenport Same for corresponding CE versions?

Apart from that consideration, LGTM.

@caseydavenport
Copy link
Member Author

Oh, yeah they will need a similar but not exactly the same change.

Let's merge this one and I will submit another PR for those.

@caseydavenport caseydavenport merged commit 26f78c9 into tigera:main Oct 29, 2024
10 checks passed
@caseydavenport caseydavenport deleted the casey-fix-calicoctl-docs branch October 29, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants