Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator changes for managed cluster #2863

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

operator changes for managed cluster #2863

wants to merge 3 commits into from

Conversation

sridhartigera
Copy link
Contributor

@sridhartigera sridhartigera commented Sep 11, 2023 •
edited
Loading

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@sridhartigera sridhartigera requested a review from a team as a code owner September 11, 2023 20:55
@marvin-tigera marvin-tigera added this to the v1.32.0 milestone Sep 11, 2023
caseydavenport
caseydavenport requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - first pass of comments done

pkg/controller/clusterconnection/clusterconnection_controller.go Outdated Show resolved Hide resolved
pkg/controller/clusterconnection/clusterconnection_controller_test.go Outdated Show resolved Hide resolved
pkg/controller/logcollector/logcollector_controller.go Outdated Show resolved Hide resolved
pkg/controller/logcollector/logcollector_controller.go Outdated Show resolved Hide resolved
pkg/controller/logcollector/logcollector_controller.go Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/node.go Show resolved Hide resolved
pkg/render/typha.go Show resolved Hide resolved
pkg/render/typha.go Show resolved Hide resolved
@danudey danudey modified the milestones: v1.32.0, v1.32.1, v1.32.2 Dec 2, 2023
@danudey danudey modified the milestones: v1.32.2, v1.32.3 Dec 15, 2023
@danudey danudey modified the milestones: v1.32.3, v1.32.4 Jan 18, 2024
@radTuti radTuti modified the milestones: v1.32.4, v1.32.5, v1.32.6 Feb 16, 2024
@radTuti radTuti modified the milestones: v1.32.6, v1.32.7 Mar 25, 2024
@danudey danudey modified the milestones: v1.32.7, v1.32.8 Apr 2, 2024
@radTuti radTuti modified the milestones: v1.32.8, v1.32.9 Apr 26, 2024
@danudey danudey modified the milestones: v1.32.9, v1.32.10 Jun 14, 2024
@danudey danudey removed this from the v1.32.10 milestone Jul 9, 2024
@danudey danudey added this to the v1.32.11 milestone Jul 9, 2024
@danudey danudey modified the milestones: v1.32.11, v1.32.12 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.32.12
Development

Successfully merging this pull request may close these issues.
5 participants
@sridhartigera @caseydavenport @danudey @radTuti @marvin-tigera