Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH #3235

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented Mar 8, 2024

Read the CgroupV2Path value from FelixConfiguration and set it as env var for the mount-bpffs node's init container.

fixes projectcalico/calico#7892

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.34.0 milestone Mar 8, 2024
@tomastigera tomastigera changed the title use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH [BPF] use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH Mar 8, 2024
pkg/render/node.go Outdated Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
Read the CgroupV2Path value from FelixConfiguration and set it as env
var for the mount-bpffs node's init container.
@agmimidi
Copy link

Hi all,

Thanks for looking into this issue! Do you know if this is still scheduled for release 1.34.0 of the operator?
From what I can see support from Calico is already there. We are running on Talos OS and would really like to enable eBPF soon on our clusters.

@radTuti radTuti modified the milestones: v1.34.0, v1.34.1 May 11, 2024
@danudey danudey modified the milestones: v1.34.1, v1.34.2 Jun 21, 2024
@danudey danudey modified the milestones: v1.34.2, v1.34.3 Jul 24, 2024
@danudey danudey modified the milestones: v1.34.3, v1.34.4 Jul 31, 2024
@danudey danudey modified the milestones: v1.34.4, v1.34.5 Sep 19, 2024
@danudey danudey modified the milestones: v1.34.5, v1.34.6, v1.34.7 Oct 22, 2024
@caseydavenport caseydavenport removed this from the v1.34.7 milestone Oct 28, 2024
@marvin-tigera marvin-tigera added this to the v1.37.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calico eBPF fails to init on Talos Linux
6 participants