Setup vsock devices for APPVMs and use it for Waypipe #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesteroff
force-pushed
the
waypipe-vsock
branch
2 times, most recently
from
40bfb97
to
1dff954
Compare
|
It's basically bad idea cause we need to know this addresses exactly for each VM to be able to address vsock endpoints. —vadik ***@***.*** 8. Sep 2023, at 13.27, Brian McGillion ***@***.***> wrote:
@brianmcgillion commented on this pull request.
In targets/lenovo-x1-carbon.nix:
@@ -120,6 +120,7 @@
macAddress = "02:00:00:03:03:05";
ramMb = 3072;
cores = 4;
+ cid = 4;
is there anyway to script this as e.g. ++cid so as to avoid hard coding for each VM?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
In this particular case APPVMs connect to GUIVM but not the other way around. It means that they only need to know the CID of the GUIVM which is always 3 (first available number). |
nesteroff
force-pushed
the
waypipe-vsock
branch
6 times, most recently
from
f6ea378
to
278c33e
Compare
mikatammi
reviewed
Sep 22, 2023
mikatammi
suggested changes
Sep 22, 2023
nesteroff
force-pushed
the
waypipe-vsock
branch
from
278c33e
to
2576c32
Compare
|
Needs rebase now |
mikatammi
reviewed
Sep 29, 2023
Signed-off-by: Yuri Nesterov <[email protected]>
nesteroff
force-pushed
the
waypipe-vsock
branch
from
2576c32
to
16c6a8d
Compare
mikatammi
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Waypipe work over VSOCK instead of UNIX domain sockets. It increases performance by getting rid of the unnecessary overhead caused by forwarding UNIX sockets over SSH. Testing with iperf show that UNIX sockets over SSH can transfer about 4 Gbits/sec on Lenovo X1 Carbon but with VSOCK it can handle about 15 Gbits/sec between GUIVM and APPVMs.