Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker bug fix #267

Closed
wants to merge 1 commit into from
Closed

Docker bug fix #267

wants to merge 1 commit into from

Conversation

emrahbillur
Copy link
Contributor

This is added to resolve the issue https://ssrc.atlassian.net/browse/SP-2697 where originated from NixOS/nixpkgs#244159. We can describe this bug as while running docker containers got a http: invalid Host header
response failing to run.
This is due to a bug in Go package in NixOS where the previous package solves this issue. Same solution can be applied Go compiler related net access bugs till next NixOS release.
When moving to NixOS 23.11, this fix will be removed as it is already fixed in the unstable channel.

@emrahbillur
Docker bug fix
a489e51 
Docker access net bug due to buggy Go compiler package fix. Unless docker is used this will not cause longer build time.

Signed-off-by: Emrah Billur <[email protected]>

_ fix

Signed-off-by: Emrah Billur <[email protected]>
@emrahbillur
Copy link
Contributor Author

Note: Unless docker is enabled this fix will not cause extra build time.

@mikatammi
Copy link
Contributor

Do we really need this? This says backport has been merged to NixOS 23.05 and it has already hit channel few months ago:
NixOS/nixpkgs#244310

https://nixpk.gs/pr-tracker.html?pr=244310

@mikatammi
Copy link
Contributor

0e14b9c

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/48e82fe1b1c863ee26a33ce9bd39621d2ada0a33' (2023-07-28)
  → 'github:NixOS/nixpkgs/e5f018cf150e29aac26c61dac0790ea023c46b24' (2023-09-12)

Of course there's slight possibility it still wasn't on the channel 9 days after the merge which happened 2023-07-19. But it should be at least now

mikatammi
mikatammi suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mikatammi mikatammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the need, after the flake input has now been updated

@emrahbillur
Copy link
Contributor Author

Please double check the need, after the flake input has now been updated

Of course. This was just a temporary fix to be removed till it was on the channel. Since it was an issue with the Go compiler, this PR was just to notify other packages that may be affected by this issue. Otherwise it was to be removed in near future.

@emrahbillur
Copy link
Contributor Author

Tested with new nixpkgs. Now not needed. Still will be accessed through closed PR's who need Go bug related backport fix.

@emrahbillur emrahbillur deleted the docker-fix branch September 20, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikatammi mikatammi mikatammi requested changes

@vilvo vilvo vilvo approved these changes

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emrahbillur @mikatammi @vilvo