Refactor VM networking #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unbel13ver
requested review from
brianmcgillion,
mikatammi,
vilvo,
vadika and
jenninikko
vilvo
reviewed
Sep 29, 2023
vilvo
reviewed
Sep 29, 2023
vilvo
reviewed
Sep 29, 2023
vilvo
reviewed
Sep 29, 2023
vilvo
suggested changes
Sep 29, 2023
jenninikko
approved these changes
Sep 29, 2023
mikatammi
reviewed
Sep 29, 2023
|
Please rebase |
unbel13ver
force-pushed
the
hostnames
branch
2 times, most recently
from
c435710
to
9e34c2b
Compare
vadika
approved these changes
Oct 3, 2023
vilvo
approved these changes
Oct 3, 2023
|
sorry needs a rebase again to fix conflicts |
*Introduce new naming pattern for VMs All VMs' names/hostnames are created using '<vmname>-vm' pattern. All VMs' network interfaces named using 'tap-<hostname>' pattern. NetVM's bridge is configured to include all 'tap-*' interfaces. This approach makes no distinction between service VMs and application VMs, but it allows to easily guess the hostname without using a network toolkit. *Introduce .ghaf local domain. All VMs except of NetVM now get their IPs from NetVM's DHCP server. The VMs are accessible by their hostnames with .ghaf postfix added, for instance, 'ssh gui-vm.ghaf'. *All VMs use separate subnet from now on, which is different from the debug-subnet. *The network configuration which is common for every VM is now extracted into the separate 'vm-networking.nix' file. Signed-off-by: Ivan Nikolaenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new naming pattern for VMs
All VMs' names/hostnames are created using '-vm' pattern. All VMs' network interfaces named using
'tap-' pattern. NetVM's bridge is configured to include all 'tap-' interfaces.
This approach makes no distinction between service VMs and application VMs, but it allows to easily guess the hostname without using a network toolkit.
*Introduce .ghaf local domain.
All VMs except of NetVM now get their IPs from NetVM's DHCP server. The VMs are accessible by their hostnames with .ghaf postfix added, for instance, 'ssh gui-vm.ghaf'.
*All VMs use separate subnet from now on, which is different from the debug-subnet.
*The network configuration which is common for every VM is now extracted into the separate 'vm-networking.nix' file.