windows-launcher: Change spice to enableSpice #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change spice to enableSpice in package arguments. This is because there exists a package called spice, so when called through callPackage the spice argument gets filled with that package, instead of defaulting to false. Signed-off-by: Mika Tammi <[email protected]>
mikatammi
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
nesteroff
approved these changes
Oct 7, 2023
|
After #307, the github action PR builder workflow also confirms that the builds for both See the full build workflow at: https://github.com/tiiuae/ghaf/actions/runs/6441216010 |
brianmcgillion
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change spice to enableSpice in package arguments. This is because there exists a package called spice, so when called through callPackage the spice argument gets filled with that package, instead of defaulting to false.