Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominate v01star as TiKV committer #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nominate v01star as TiKV committer #223

wants to merge 1 commit into from
+24 −2

Conversation

Connor1996
Copy link
Member

No description provided.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zhangjinpeng87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Oct 16, 2024
overvenus
overvenus approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2024

@overvenus: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Congrats!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zhangjinpeng87
zhangjinpeng87 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 16, 2024
AndreMouche
AndreMouche approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description with the proposal content for this PR, Rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2024

@AndreMouche: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Please add a description with the proposal content for this PR, Rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sunxiaoguang
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@overvenus overvenus overvenus approved these changes

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Connor1996 @sunxiaoguang @AndreMouche @overvenus @zhangjinpeng87 @v01dstar