Add grpc_rs for exporting internal APIs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <[email protected]>
By following command
tools/buildgen/generate_projects.sh \
--templates templates/CMakeLists.txt.template
Signed-off-by: Neil Shen <[email protected]>
BusyJay
reviewed
Aug 8, 2023
| @@ -534,6 +534,25 @@ GRPCXX_PUBLIC_HDRS = [ | |||
| "include/grpcpp/impl/codegen/sync.h", | |||
| ] | |||
|
|
|||
| grpc_cc_library( | |||
There was a problem hiding this comment.
So that code can be placed outside of src/core and let grpc and grpc_unsecure depends on it using its build system.
Anyway, what's your suggestion?
There was a problem hiding this comment.
Why not put the source in the source list just like CMakeLists.txt does?
There was a problem hiding this comment.
CMakeLists.txt is generated from BUILD, upstream may overwrite CMakeLists.txt if they add or remove a file.
There was a problem hiding this comment.
@BusyJay PTAL, thanks!
There was a problem hiding this comment.
I'm a bit confused. Now is CMakeLists.txt auto-generated? Note we always need to modify CMakeLists.txt as the generated one from upstream doesn't always compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.